Skip to content

fix(valgrind): skip rustup-wrapped proxy in trace-children#405

Merged
not-matthias merged 1 commit into
mainfrom
cod-2850-codspeed-cli-fails-with-rustup-proxy-error-in-nix-flake
Jun 16, 2026
Merged

fix(valgrind): skip rustup-wrapped proxy in trace-children#405
not-matthias merged 1 commit into
mainfrom
cod-2850-codspeed-cli-fails-with-rustup-proxy-error-in-nix-flake

Conversation

@not-matthias

@not-matthias not-matthias commented Jun 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-2850-codspeed-cli-fails-with-rustup-proxy-error-in-nix-flake branch from 723f6f7 to b41f203 Compare June 12, 2026 14:57
@not-matthias not-matthias marked this pull request as ready for review June 12, 2026 14:57
@greptile-apps

greptile-apps Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Greptile Summary

Adds *.rustup-wrapped to Valgrind's --trace-children-skip pattern list so that Nix's rustup wrapper proxy is not traced. Without this, Valgrind modifies argv[0] when entering the wrapper, breaking rustup's proxy detection logic.

  • src/executor/valgrind/measure.rs: Extends children_skip_patterns with "*.rustup-wrapped" and adds a unit test confirming the argument is emitted by get_valgrind_args.

Confidence Score: 5/5

Safe to merge — a one-line glob addition to an existing skip list, with a comment and a matching unit test.

The change is narrowly scoped: it appends a single glob pattern to an already-used --trace-children-skip argument. The existing *esbuild entry proves the mechanism works; the new *.rustup-wrapped entry follows the same pattern and is protected by a new unit test that asserts the arg is emitted. No existing behavior is altered.

No files require special attention.

Important Files Changed

Filename Overview
src/executor/valgrind/measure.rs Adds "*.rustup-wrapped" skip pattern and a focused unit test; logic is straightforward with a clear comment.

Flowchart

 
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Valgrind launches bench binary] --> B{trace-children=yes}
    B --> C{Child process path matches skip pattern?}
    C -->|"*.rustup-wrapped (NEW)"| D[Skip tracing — rustup proxy unaffected]
    C -->|"*esbuild"| D
    C -->|No match| E[Trace child process normally]
Loading 
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Valgrind launches bench binary] --> B{trace-children=yes}
    B --> C{Child process path matches skip pattern?}
    C -->|"*.rustup-wrapped (NEW)"| D[Skip tracing — rustup proxy unaffected]
    C -->|"*esbuild"| D
    C -->|No match| E[Trace child process normally]
Loading

Reviews (2): Last reviewed commit: "fix(valgrind): skip rustup-wrapped proxy..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks

Comparing cod-2850-codspeed-cli-fails-with-rustup-proxy-error-in-nix-flake (7c50010) with main (9e21a9c)

Open in CodSpeed

@not-matthias
fix(valgrind): skip rustup-wrapped proxy in trace-children
7c50010 
Valgrind rewrites argv[0] when tracing Nix's rustup wrapper, breaking
rustup proxy detection. Add *.rustup-wrapped to --trace-children-skip.
@not-matthias not-matthias force-pushed the cod-2850-codspeed-cli-fails-with-rustup-proxy-error-in-nix-flake branch from b41f203 to 7c50010 Compare June 16, 2026 13:29
@not-matthias not-matthias merged commit 7c50010 into main Jun 16, 2026
22 checks passed
@not-matthias not-matthias deleted the cod-2850-codspeed-cli-fails-with-rustup-proxy-error-in-nix-flake branch June 16, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeLagrange GuillaumeLagrange GuillaumeLagrange approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@not-matthias @GuillaumeLagrange